Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ignore RWLock from Istanbul coverage #32478

Merged
merged 4 commits into from
Dec 12, 2024
Merged

chore: ignore RWLock from Istanbul coverage #32478

merged 4 commits into from
Dec 12, 2024

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Dec 11, 2024

This periodically blocks PRs on CodeCov if the locking logic nondeterminstically happens to have taken another path.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
chore: ignore RWLock from Istanbul coverage
d9e95e7 
This periodically blocks PRs on CodeCov if the locking logic
nondeterminstically happens to have taken another path.
@rix0rrr rix0rrr requested a review from a team as a code owner December 11, 2024 15:50
@aws-cdk-automation aws-cdk-automation requested a review from a team December 11, 2024 15:50
@github-actions github-actions bot added the p2 label Dec 11, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 11, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 11, 2024
@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested labels Dec 11, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 11, 2024 16:01

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 11, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.60%. Comparing base (225d261) to head (f47df59).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #32478      +/-   ##
==========================================
- Coverage   78.67%   78.60%   -0.08%     
==========================================
  Files         107      107              
  Lines        7237     7161      -76     
  Branches     1329     1320       -9     
==========================================
- Hits         5694     5629      -65     
+ Misses       1357     1347      -10     
+ Partials      186      185       -1
Flag Coverage Δ
suite.unit 78.60% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.60% <ø> (-0.08%) ⬇️

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Dec 11, 2024

Didn't work

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f47df59
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr merged commit fe7d435 into main Dec 12, 2024
12 of 15 checks passed
@rix0rrr rix0rrr deleted the ignore-rwlock branch December 12, 2024 11:15
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sumupitchayan sumupitchayan sumupitchayan approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rix0rrr @aws-cdk-automation @sumupitchayan